Migrate to distroless/java11-debian11 as base OS #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvrl
reviewed
Feb 7, 2023
| @@ -17,7 +17,7 @@ | |||
| # under the License. | |||
| # | |||
|
|
|||
| ARG JDK_VERSION=8 | |||
| ARG JDK_VERSION=11 | |||
There was a problem hiding this comment.
note that this argument is just the default. I think it's ok to change it, but the actual value for the argument actually gets defined via https://github.com/confluentinc/druid/blob/24.0.2-confluent/distribution/pom.xml#L46
There was a problem hiding this comment.
Agreed, upstream it was also updated to 11 as the default in the dockerfile as well so figured we should here
There was a problem hiding this comment.
The version we run still defaults to 8 https://github.com/apache/druid/blob/druid-24.0.2/distribution/docker/Dockerfile#L20, but since distroless doesn't have 8 anymore changing it here makes sense.
xvrl
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See upstream Dockerfile: https://github.com/apache/druid/blob/master/distribution/docker/Dockerfile#LL53-L54C49
See also (internal): https://github.com/confluentinc/cc-druid/pull/1154